refactor: isCLI() does not use is_cli()

codeigniter4 · Jun 23, 2022 · c31570d · c31570d
1 parent 388c4b5
commit c31570d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/system/HTTP/CLIRequest.php b/system/HTTP/CLIRequest.php
@@ -212,6 +212,6 @@ protected function parseCommand()
  */
  public function isCLI(): bool
  {
- return is_cli();
+ return true;
  }
 }
diff --git a/system/HTTP/IncomingRequest.php b/system/HTTP/IncomingRequest.php
@@ -347,7 +347,7 @@ public function negotiate(string $type, array $supported, bool $strictMatch = fa
  */
  public function isCLI(): bool
  {
- return is_cli();
+ return false;
  }
 
  /**

diff --git a/tests/system/CommonSingleServiceTest.php b/tests/system/CommonSingleServiceTest.php
@@ -95,6 +95,7 @@ public static function serviceNamesProvider(): iterable
  static $services = [];
  static $excl = [
  '__callStatic',
+ 'createRequest',
  'serviceExists',
  'reset',
  'resetSingle',

diff --git a/tests/system/HTTP/IncomingRequestTest.php b/tests/system/HTTP/IncomingRequestTest.php
@@ -438,8 +438,7 @@ public function testCanGrabGetRawInput()
 
  public function testIsCLI()
  {
- // this should be the case in unit testing
- $this->assertTrue($this->request->isCLI());
+ $this->assertFalse($this->request->isCLI());
  }
 
  public function testIsAJAX()