feat: improve spark routes output for View routes

codeigniter4 · Jul 4, 2023 · d2af631 · d2af631
1 parent c1b8f4d
commit d2af631
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/system/Router/DefinedRouteCollector.php b/system/Router/DefinedRouteCollector.php
@@ -48,7 +48,9 @@ public function collect(): Generator
  if (is_string($handler) || $handler instanceof Closure) {
 
  if ($handler instanceof Closure) {
- $handler = '(Closure)';
+ $view = $this->routeCollection->getRoutesOptions($route, $method)['view'] ?? false;
+
+ $handler = $view ? '(View) ' . $view : '(Closure)';
  }
 
  $routeName = $this->routeCollection->getRoutesOptions($route)['as'] ?? $route;

diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -1101,7 +1101,10 @@ public function view(string $from, string $view, ?array $options = null): RouteC
  ->setData(['segments' => $data], 'raw')
  ->render($view, $options);
 
- $this->create('get', $from, $to, $options);
+ $routeOptions = $options ?? [];
+ $routeOptions = array_merge($routeOptions, ['view' => $view]);
+
+ $this->create('get', $from, $to, $routeOptions);
 
  return $this;
  }

diff --git a/tests/system/Router/DefinedRouteCollectorTest.php b/tests/system/Router/DefinedRouteCollectorTest.php
@@ -82,7 +82,7 @@ public function test()
  'method' => 'get',
  'route' => 'about',
  'name' => 'about',
- 'handler' => '(Closure)',
+ 'handler' => '(View) pages/about',
  ],
  ];
  $this->assertSame($expected, $definedRoutes);