fix: spark can't use options in PHP 7.4

Cannot unpack array with string keys
at SYSTEMPATH/CodeIgniter.php:893

system/CLI/CommandRunner.php

@@ -40,13 +40,13 @@ public function __construct()
  * so we have the chance to look for a Command first.
  *
  * @param string $method
- * @param array ...$params
+ * @param array $params
  *
  * @throws ReflectionException
  *
  * @return mixed
  */
- public function _remap($method, ...$params)
+ public function _remap($method, $params)
  {
  // The first param is usually empty, so scrap it.
  if (empty($params[0])) {

system/CodeIgniter.php

@@ -884,14 +884,16 @@ protected function runController($class)
  /** @var CLIRequest $request */
  $request = $this->request;
  $params = $request->getArgs();
+
+ $output = $class->_remap($this->method, $params);
  } else {
  // This is a Web request or PHP CLI request
  $params = $this->router->params();
- }
 
- $output = method_exists($class, '_remap')
- ? $class->_remap($this->method, ...$params)
- : $class->{$this->method}(...$params);
+ $output = method_exists($class, '_remap')
+ ? $class->_remap($this->method, ...$params)
+ : $class->{$this->method}(...$params);
+ }
 
  $this->benchmark->stop('controller');
 

tests/system/CLI/CommandRunnerTest.php

@@ -123,7 +123,7 @@ public function testBadCommand()
  */
  public function testRemapEmptyFirstParams()
  {
- self::$runner->_remap('anyvalue', null, 'list');
+ self::$runner->_remap('anyvalue', [null, 'list']);
  $result = CITestStreamFilter::$buffer;
 
  // make sure the result looks like a command list

tests/system/SparkTest.php

@@ -0,0 +1,29 @@
+<?php
+
+/**
+ * This file is part of CodeIgniter 4 framework.
+ *
+ * (c) CodeIgniter Foundation <admin@codeigniter.com>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace CodeIgniter;
+
+use CodeIgniter\Test\CIUnitTestCase;
+
+/**
+ * @internal
+ */
+final class SparkTest extends CIUnitTestCase
+{
+ public function testCanUseOption()
+ {
+ ob_start();
+ passthru('php spark list --simple');
+ $output = ob_get_clean();
+
+ $this->assertStringContainsString('cache:clear', $output);
+ }
+}