Merge pull request #2507 from codeigniter4/searchorder

Update ordering of search locations for better prioritization. Fixes #2354
codeigniter4 · Jan 23, 2020 · fc195f7 · fc195f7
2 parents 0eedc0e + 2c7aa2c
commit fc195f7
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/app/Config/Autoload.php b/app/Config/Autoload.php
@@ -50,9 +50,9 @@ public function __construct()
 		 *   `];
 		 */
 		$psr4 = [
-			'Config'      => APPPATH . 'Config',
-			APP_NAMESPACE => APPPATH,                // For custom namespace
 			'App'         => APPPATH,                // To ensure filters, etc still found,
+			APP_NAMESPACE => APPPATH,                // For custom namespace
+			'Config'      => APPPATH . 'Config',
 		];
 
 		/**

diff --git a/system/Autoloader/FileLocator.php b/system/Autoloader/FileLocator.php
@@ -287,17 +287,32 @@ protected function getNamespaces()
 	{
 		$namespaces = [];
 
+		// Save system for last
+		$system = null;
+
 		foreach ($this->autoloader->getNamespace() as $prefix => $paths)
 		{
 			foreach ($paths as $path)
 			{
+				if ($prefix === 'CodeIgniter')
+				{
+					$system = [
+						'prefix' => $prefix,
+						'path'   => rtrim($path, '\\/') . DIRECTORY_SEPARATOR,
+					];
+
+					continue;
+				}
+
 				$namespaces[] = [
 					'prefix' => $prefix,
 					'path'   => rtrim($path, '\\/') . DIRECTORY_SEPARATOR,
 				];
 			}
 		}
 
+		$namespaces[] = $system;
+
 		return $namespaces;
 	}
 

diff --git a/tests/system/Autoloader/FileLocatorTest.php b/tests/system/Autoloader/FileLocatorTest.php
@@ -22,8 +22,8 @@ protected function setUp(): void
 			'Tests/Support' => TESTPATH . '_support/',
 			'App'           => APPPATH,
 			'CodeIgniter'   => [
-				SYSTEMPATH,
 				TESTPATH,
+				SYSTEMPATH,
 			],
 			'Errors'        => APPPATH . 'Views/errors',
 			'System'        => SUPPORTPATH . 'Autoloader/system',
@@ -170,7 +170,6 @@ public function testSearchWithMultipleFilesFound()
 		$this->assertContains($expected, $foundFiles);
 
 		$expected = SYSTEMPATH . 'index.html';
-
 		$this->assertContains($expected, $foundFiles);
 	}
 

diff --git a/tests/system/Language/LanguageTest.php b/tests/system/Language/LanguageTest.php
@@ -221,7 +221,7 @@ public function testPrioritizedLocator()
 		$language = Services::language('en', false);
 		// this should load the replacement bundle of messages
 		$message = lang('Core.missingExtension', [], 'en');
-		$this->assertEquals('{0} extension could not be found.', $message);
+		$this->assertEquals('{0} extension is not loaded.', $message);
 		// and we should have our new message too
 		$this->assertEquals('billions and billions', lang('Core.bazillion', [], 'en'));
 	}