fix: CLI::prompt() may incorrectly return default value

See CLITest::testPromptInputZero().
codeigniter4 · May 8, 2024 · ffbb4b7 · ffbb4b7
1 parent aa1d6c6
commit ffbb4b7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php
@@ -258,7 +258,8 @@ public static function prompt(string $field, $options = null, $validation = null
  static::fwrite(STDOUT, $field . (trim($field) !== '' ? ' ' : '') . $extraOutput . ': ');
 
  // Read the input from keyboard.
- $input = trim(static::$io->input()) ?: (string) $default;
+ $input = trim(static::$io->input());
+ $input = ($input === '') ? (string) $default : $input;
 
  if ($validation !== []) {
  while (! static::validate('"' . trim($field) . '"', $input, $validation)) {