-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Toolbar error not found tpl error and fix #2275
Comments
/system/View/Parser.php `$fileExt = pathinfo($view, PATHINFO_EXTENSION);
|
fix |
I noticed this today as well. @dayrui I'm not sure where your fix ix supposed to go - could you send over a PR? Or clarify? Did you mean to add before line 146:
So the updated version is:
I think that doesn't fix the problem of allowing other extensions, just compound extensions. |
I think changing the file extensions in system/Debug/Toolbar/Views from |
That works for everything except toolbar.tpl.php which appears to be included separately and needs the compound extension. |
I' am also getting an Error |
@jim-parry We might need to consider a hotfix or the Toolbar isn’t going to work until RC.3. Could you or @lonnieezell check out #2280 and #2281 and decide on an approach, then we can at least get dev patched? |
My preference would be to have them have just a ".tpl" file extension. That would let us eliminate a phpunit filter and keep them out of the testing more cleanly. However, I don't where these are all used. and I would be surprised if it's just a matter of renaming them. I did a search in my IDE, and found Commands/Sessions/CreateMigration and Debug/Toolbar. Is that all that uses them? If we are thinking a hotfix, the cleanest would be to have all the changes in the one PR, which would then be based on master, not develop. |
Something niggly that might be impacting the toolbar: Debug/Toolbar/Views/toolbarloader.js.php has messed up quoting, lines 78-79 |
In |
The tests don't break, but there is no Debug/ToolbarTest, so we wouldn't know :( toolbar.tpl.php is referenced in Toolbar::495. That would need to be changed as part of #2280. |
It sounds like we are on the same page, and online at the same time. Weird, but effective! |
toolbar.tpl.php is actually a PHP file and is included directly rather than passed through the parser. I'm not sure why it has the Re: tests I have been using the toolbar with renamed templates in my dev environment and can confirm that all collectors work and the toolbar displays. |
Okay #2283 sent - does nothing except rename the actual templates for collector views. PR is for master, not sure how you want to handle that and if to release. |
This would affect the codeigniter4, appstarter and framework distributions. |
I’m late to the party ok this one but the bigger question I have is why don’t .pho extensions work anymore? I know we had the recent PR that allowed different extensions on the parser but didn’t realize that killed the ability to use the current extension.
…Sent from my iPhone
On Sep 28, 2019, at 9:13 AM, Project lead, CodeIgniter ***@***.***> wrote:
This would affect the codeigniter4, appstarter and framework distributions.
I will merge & update the releases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@lonnieezell See #2283 - Matthew explained that in the "fix" |
@lonnieezell I need to hotfix the framework distro as is. Does is make sense to include this change, and redo all three distros and the codebase repo? If so, is it ok to just re-release them, or should be do an "rc.2b"? |
Probably better to give it a new release name I would think.
…Sent from my iPhone
On Sep 28, 2019, at 9:52 AM, Project lead, CodeIgniter ***@***.***> wrote:
@lonnieezell I need to hotfix the framework distro as is. Does is make sense to include this change, and redo all three distros and the codebase repo? If so, is it ok to just re-release them, or should be do an "rc.2b"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Agreed. I had to do that before too. |
Resolved by 8ba099e |
Describe the bug
NOT FOUND (/var/www/www-root/data/www/site.com/system/Debug/Toolbar/Views/_database.tpl) -> real name _database.tpl.php
Fix
_database.tpl.php copy and rename _database.tpl and etc files
CodeIgniter 4 version
4.0.0-rc.2
Affected module(s)
Which package or class is the bug in, if known.
CRITICAL - 2019-09-27 11:33:34 --> Invalid file: {0}
#0 /var/www/www-root/data/www/site.com/system/View/Parser.php(156): CodeIgniter\Exceptions\FrameworkException::forInvalidFile('') -> NOT FOUND (/var/www/www-root/data/www/site.com/system/Debug/Toolbar/Views/_database.tpl) -> real name _database.tpl.php
#1 /var/www/www-root/data/www/site.com/system/Debug/Toolbar/Views/toolbar.tpl.php(139): CodeIgniter\View\Parser->render('_files.tpl')
#2 /var/www/www-root/data/www/site.com/system/Debug/Toolbar.php(495): include('/var/www/www-ro...')
#3 /var/www/www-root/data/www/site.com/system/Debug/Toolbar.php(453): CodeIgniter\Debug\Toolbar->format(Array, 'html')
#4 /var/www/www-root/data/www/site.com/app/Config/Events.php(41): CodeIgniter\Debug\Toolbar->respond()
#5 [internal function]: CodeIgniter\Events\Events::Config{closure}()
#6 /var/www/www-root/data/www/site.com/system/Events/Events.php(187): call_user_func(Object(Closure))
#7 /var/www/www-root/data/www/site.com/system/CodeIgniter.php(226): CodeIgniter\Events\Events::trigger('pre_system')
#8 /var/www/www-root/data/www/site.com/public_html/index.php(45): CodeIgniter\CodeIgniter->run()
#9 {main}
Context
The text was updated successfully, but these errors were encountered: