Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: SQLite3\Table::copyData() does not escape column names #5946

Closed
kenjis opened this issue May 1, 2022 · 0 comments · Fixed by #6055
Closed

Bug: SQLite3\Table::copyData() does not escape column names #5946

kenjis opened this issue May 1, 2022 · 0 comments · Fixed by #6055
Assignees
@kenjis
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Comments

@kenjis
Copy link
Member

kenjis commented May 1, 2022 •
edited
Loading

See codeigniter4/shield#91 (comment)

CodeIgniter4/system/Database/SQLite3/Table.php

Lines 264 to 269 in aee95af

/**
* Copies data from our old table to the new one,
* taking care map data correctly based on any columns
* that have been renamed.
*/
protected function copyData()

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels May 1, 2022
@kenjis kenjis self-assigned this May 31, 2022
@kenjis kenjis mentioned this issue May 31, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenjis kenjis

Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: SQLite3\Table::copyData() does not escape column names kenjis/CodeIgniter4
1 participant
@kenjis