Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SQLite3\Table::copyData() does not escape column names #6055

Merged
merged 4 commits into from
Jun 1, 2022
Merged

fix: SQLite3\Table::copyData() does not escape column names #6055

merged 4 commits into from
Jun 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 31, 2022

Description
Fixes #5946

  • fix SQLite3\Table::copyData()
  • fix SQLite3 test assertion that raises a hidden error

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels May 31, 2022
@kenjis kenjis merged commit b05533c into codeigniter4:develop Jun 1, 2022
@kenjis kenjis deleted the fix-sqlite3-Table-copyData branch June 1, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: SQLite3\Table::copyData() does not escape column names
3 participants
@kenjis @samsonasik @paulbalandan