-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: There are cases where the name of a named route is not determined. #8039
Labels
bug
Verified issues on the current code behavior or pull requests that will fix them
Comments
tomomo
added
the
bug
Verified issues on the current code behavior or pull requests that will fix them
label
Oct 13, 2023
Thank you for reporting. This seems to be a bug in the Try: --- a/system/Router/DefinedRouteCollector.php
+++ b/system/Router/DefinedRouteCollector.php
@@ -57,7 +57,7 @@ final class DefinedRouteCollector
$handler = $view ? '(View) ' . $view : '(Closure)';
}
- $routeName = $this->routeCollection->getRoutesOptions($route)['as'] ?? $route;
+ $routeName = $this->routeCollection->getRoutesOptions($route, $method)['as'] ?? $route;
yield [
'method' => $method, |
Thank you for your prompt reply.
I confirmed that there was a change in login (POST). |
5 tasks
Thank you for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PHP Version
8.2
CodeIgniter4 Version
4.4.1
CodeIgniter4 Installation Method
Composer (using
codeigniter4/appstarter
)Which operating systems have you tested for this bug?
macOS
Which server did you use?
apache
Database
No response
What happened?
There are cases where the name of a named route is not determined.
Unnamed or duplicate.
"logout" cannot be named.
"login(GET or POST") has the same name.(Is this the specification?)
Steps to Reproduce
Add the following to
app/Config/Routes.php
Expected Output
Check with
php spark routes
etc."logout" cannot be named.
"login(GET or POST") has the same name.(Is this the specification?)
Anything else?
No response
The text was updated successfully, but these errors were encountered: