Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spark routes may show incorrect route names #8040

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix: spark routes may show incorrect route names #8040

merged 3 commits into from
Oct 16, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 13, 2023

Description
Fixes #8039

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 13, 2023
@kenjis kenjis mentioned this pull request Oct 13, 2023
Closed
@kenjis kenjis merged commit 21132d4 into codeigniter4:develop Oct 16, 2023
62 checks passed
@kenjis kenjis deleted the fix-spark-routes-bug branch October 16, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: There are cases where the name of a named route is not determined.
2 participants
@kenjis @michalsn