Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update View.php #1130

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Update View.php #1130

merged 1 commit into from
Aug 9, 2018

Conversation

sugenganthos
Copy link
Contributor

Allow views with extension .html, .tpl, empty (assume as .php), etc

Allow views with extension .html, .tpl, empty (assume as .php), etc
@lonnieezell
Copy link
Member

Thanks for this. Looks fine.

Please add some documentation for this ability. A test wouldn't hurt either.

@sugenganthos
Copy link
Contributor Author

About docs, if you say about inline, i think my inline comment is sufficient. If you say about user documentation, I need some time to find where :)

For test, if you say about PHPUnit and something else, I never use that, and don't know how to use it. Sorry. I just use localhost to test everything.

@lonnieezell
Copy link
Member

Ok, that's fine about tests. Docs should be added to this file.

@lonnieezell lonnieezell merged commit fd875fe into codeigniter4:develop Aug 9, 2018
@sugenganthos sugenganthos deleted the patch-2 branch August 16, 2018 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants