Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headerEmited (or not) assertions to CIUnitTestCase #1312

Merged
merged 11 commits into from
Oct 26, 2018

Conversation

jim-parry
Copy link
Contributor

@jim-parry jim-parry commented Oct 14, 2018

  • Enhance system/Test/CIUnitTestCase as above
  • update user guide testing/overview page
  • update constant definitions in application/Config/Boot since they could be called more than once
  • updated server requirements in repo root to match those in the user guide

These are prep for the header & cookie testing which is in proress.

@jim-parry
Copy link
Contributor Author

ps, on CentOS, libcurl is a standard extension, and can just be yum installed

@jim-parry
Copy link
Contributor Author

@lonnieezell Hoping you can point me in the right direction. When I run phpunit on tests/system/Test, all is well. When they are run against the entire suite, as in travis-ci, the index page is spat out, together with an exception (undefined variable namespace). Sample at https://travis-ci.org/bcit-ci/CodeIgniter4/jobs/441425539. I seem to recall this coming up before, but cannot remember the fix.
Thanks.

@jim-parry jim-parry changed the title Add headerEmited (or not) assertions to CUUnitTestCase WIP Add headerEmited (or not) assertions to CUUnitTestCase Oct 19, 2018
@jim-parry jim-parry changed the title WIP Add headerEmited (or not) assertions to CUUnitTestCase WIP Add headerEmited (or not) assertions to CIUnitTestCase Oct 25, 2018
@jim-parry jim-parry changed the title WIP Add headerEmited (or not) assertions to CIUnitTestCase Add headerEmited (or not) assertions to CIUnitTestCase Oct 26, 2018
@jim-parry jim-parry merged commit e6a6d64 into codeigniter4:develop Oct 26, 2018
@jim-parry
Copy link
Contributor Author

ps - It could have been me introducing non-signed commits ... merge commits specifically, synching with latest develop branch. I need to remember to do "git merge -S develop" in my feature branches to synch :-/

@jim-parry jim-parry deleted the enhance/testing branch October 26, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants