Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase 'vfsStream' in composer files #1755

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Feb 23, 2019

Description
Composer gives warnings about uppercase letters in paths. It looks like this one was missed at some point - fixing across 3 package locations.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@jim-parry
Copy link
Contributor

Looks good, thanks.
For future reference, commits need to be GPG-signed. You checked that box, but did not securely sign your commit:-/

@MGatner
Copy link
Member Author

MGatner commented Feb 23, 2019

Yes sorry about that, all my previous ones were and I’m confused why this one wasn’t. I was just researching and found git config commit.gpgsign true - I’ll give it a go for next time. Thanks for the fast response!

@jim-parry
Copy link
Contributor

just setting the git config isn't enough ... the signing keys need to be registered with your github account, and yout local git user.email needs to match that on your github account too

@MGatner
Copy link
Member Author

MGatner commented Feb 23, 2019

Yes I have both of those in place already which is why I was confused that it didn't show up as signed - I think this setting was the missing piece. Will test now.

@jim-parry jim-parry merged commit 6ed4aa7 into codeigniter4:develop Feb 23, 2019
@MGatner MGatner deleted the composer-caps-fix branch February 23, 2019 18:25
@MGatner
Copy link
Member Author

MGatner commented Feb 23, 2019

Okay you're right that was not as straightforward as I thought! Got it all set though:
MGatner@961ca68
I'll be sure to be verified next time. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants