Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing return #2189

Merged
merged 2 commits into from
Sep 5, 2019
Merged

missing return #2189

merged 2 commits into from
Sep 5, 2019

Conversation

titounnes
Copy link
Contributor

get_class() expects parameter 1 to be object, string given

Each pull request should address a single issue and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345)
  • Unsolicited pull requests will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

get_class() expects parameter 1 to be object, string given
@titounnes titounnes changed the title Update restful.rst missing return Sep 5, 2019
@jim-parry
Copy link
Contributor

Good catch on the documentation error, but your PR description is totally irrelevant! Please be more mindful of that in future!

@jim-parry jim-parry merged commit 847b1c1 into codeigniter4:develop Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants