Exclude sqlite_%
from listTables()
#2228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SQLite will ad-hoc add various tables prefixed "sqlite_" that function similar to MySQL's
information_schema
. See for example these metadata test results (https://travis-ci.org/codeigniter4/CodeIgniter4/jobs/586068130):... where
sqlite_sequence
is being returned as a table. I think these tables should be excluded as system data to be consistent with the other database drivers. E.g. if I use forge to add two tables to an empty database,listTables()
should return two tables regardless of driver.Checklist: