Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert RedirectException change #2338

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Revert RedirectException change #2338

merged 4 commits into from
Oct 16, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 16, 2019 •
edited
Loading

Description
#1769 changed CodeIgniter.php to catch FilterException instead of RedirectException, which breaks redirect routing via exception and introduced the "filter blank page" issue (#2077).

This PR changes the exception back to the correct exception type.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member Author

MGatner commented Oct 16, 2019

Now also updates RedirectException to provide route (as it was intended) instead of the error message.

@lonnieezell
Copy link
Member

Looks good to me. Feel free to merge as long as tests don't crash.

@MGatner
Copy link
Member Author

MGatner commented Oct 16, 2019

Here goes!

@MGatner MGatner merged commit 4b5d922 into codeigniter4:develop Oct 16, 2019
@MGatner MGatner deleted the redirectexception branch October 16, 2019 17:57
@nyufeng nyufeng mentioned this pull request Jan 10, 2020
Closed
@sfadschm sfadschm mentioned this pull request Dec 1, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell