Debug Toolbar - Fix Debugbar-Time header, Render in <head> #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…<head> - There is an issue with Debugbar-Time not being set corretly XHR respspone when integer value is set. This fixes the toolbar to pick up changes on ajax request - Debug toolbar scripts should be rendered immedeately the beginning of <head> in order to pick up ajax requests which happens on document load.
|
Hi, I have this fixed that might help. system/debug/toolbar/views/toolbarloader.js.php line 75. Add the condition below: # if (realXHR.getAllResponseHeaders().indexOf("Debugbar-Time") >= 0) {complete code: if (realXHR.readyState === 4 && realXHR.status.toString()[0] === '2' && realXHR.responseURL.indexOf('debugbar_time') === -1) {
if (realXHR.getAllResponseHeaders().indexOf("Debugbar-Time") >= 0) {
var debugbarTime = realXHR.getResponseHeader('Debugbar-Time');
if (debugbarTime) {
var h2 = document.querySelector('#ci-history > h2');
if (h2) {
h2.innerHTML = 'History <small>You have new debug data.</small> <button onclick="loadDoc(' + debugbarTime + ')">Update</button>';
var badge = document.querySelector('a[data-tab="ci-history"] > span > .badge');
badge.className += ' active';
}
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue with Debugbar-Time not being set correctly XHR response when integer value is set. This fixes the toolbar to pick up changes on Ajax request
Debug toolbar scripts should be rendered immediately the beginning of in order to pick up Ajax requests which happens on document load.
Checklist: