Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx_rtd_theme from version 0.2.4 to version 0.4.3 #2596

Conversation

LittleJ
Copy link
Contributor

@LittleJ LittleJ commented Feb 23, 2020

Description
Update sphinx_rtd_theme from version 0.2.4 to version 0.4.3

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@LittleJ LittleJ changed the title Update sphinx_rtd theme from 0.2.4 to 0.4.3 Update sphinx_rtd_theme from version 0.2.4 to version 0.4.3 Feb 23, 2020
@LittleJ LittleJ requested a review from lonnieezell February 23, 2020 23:30
@MGatner
Copy link
Member

MGatner commented Feb 23, 2020

Wow, this looks great! I have literally zero Sphinx experience so I’m going to let @lonnieezell look at this, but assuming it is bringing a version up to the latest this would be great to have in the initial release.

@lonnieezell
Copy link
Member

I pulled them down and checked out the changes and it looks fantastic. Thanks!

@lonnieezell lonnieezell merged commit bfae89e into codeigniter4:develop Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants