Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webp support to Image class #3176

Merged
merged 7 commits into from
Jul 1, 2020

Conversation

michalsn
Copy link
Member

Description
This is the corrected code added in #3084.
I thought leaving the original author of this code will be fair, so some changes are not be signed.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @lonnieezell will need to merge since there are unsigned commits.

@lonnieezell lonnieezell merged commit 91a5742 into codeigniter4:develop Jul 1, 2020
@michalsn michalsn deleted the webp_support branch July 3, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants