Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide in bootstrap4 #3197

Merged
merged 10 commits into from
Jul 11, 2020
Merged

Hide in bootstrap4 #3197

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7af80ea
Hide in bootstrap4
Sosko Jul 2, 2020
162fab1
Add Honeypot config for hiding string
Sosko Jul 3, 2020
c88c017
Add hidennby string to the output of template
Sosko Jul 3, 2020
a80c2f0
hidden extended via hiddenByClass and hiddenContainer
Sosko Jul 7, 2020
de9be9e
Usage of config hiddenContainer and hiddenByClass
Sosko Jul 7, 2020
4fa3424
Update system/Honeypot/Honeypot.php
Sosko Jul 8, 2020
9716d30
Update system/Honeypot/Honeypot.php
Sosko Jul 8, 2020
47369e4
Update app/Config/Honeypot.php
Sosko Jul 8, 2020
1fe681b
Update Honeypot.php
Sosko Jul 8, 2020
c76b1dd
Update Honeypot.php
Sosko Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/Config/Honeypot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ class Honeypot extends BaseConfig
* @var boolean
*/
public $hidden = true;
/**
* Hide the Honypot. The default is style, but if the CSP is enabled, it is better to use class.
* Example:
* public $hiddenBy = 'class="hidden"';
*
* @var string
*/
public $hiddenBy = 'style="display:none"';
michalsn marked this conversation as resolved.
Show resolved Hide resolved
/**
* Honeypot Label Content
*
Expand Down
6 changes: 5 additions & 1 deletion system/Honeypot/Honeypot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ function __construct(BaseConfig $config)
{
throw HoneypotException::forNoHiddenValue();
}
if ($this->config->hiddenBy === '')
michalsn marked this conversation as resolved.
Show resolved Hide resolved
{
throw HoneypotException::forNoHiddenValue();
}

if ($this->config->template === '')
{
Expand Down Expand Up @@ -124,7 +128,7 @@ protected function prepareTemplate(string $template): string

if ($this->config->hidden)
{
$template = '<div style="display:none">' . $template . '</div>';
$template = '<div ' . $this->config->hiddenBy . '>' . $template . '</div>';
michalsn marked this conversation as resolved.
Show resolved Hide resolved
}
return $template;
}
Expand Down