[FilesCollection] Allow getFiles with dot syntax #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lonnieezell
requested changes
Jan 6, 2017
| $file = $this->request->getFile('avatar'); | ||
|
|
||
| .. note:: This currently only works with simple file names and not with array syntax naming. | ||
| $file = $this->request->getFile('my-form.details.avatar.0'); |
There was a problem hiding this comment.
A couple of things:
- We should still show that you can access the simple case
$this->request->getFile('avatar');. - If there are multiple files with the same name, then your example applies, but what if there's only one file with a deep name? Basically - we should show all three methods in the docs.
// Get a single file
$file = $this->request->getFile('avatar');
// Get a single file within a more complex path
$file = $this->request->getFile('my-form.details.avatar');
// Get the first of several files uploaded under the same name
$file = $this->request->getFile('my-form.details.avatar.0');
Looking at the code, I believe those cases will all pass currently, and we need them to. :)
There was a problem hiding this comment.
Hi @lonnieezell Thanks!
Sorry for the brevity in the User Guide. My English is very poor. In the next few days I will write some examples
|
Hi @lonnieezell Done! I have written some examples. If necessary can you correct the user guide? Thanks! |
|
Looks good. Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FilesCollection] Allow getFiles with dot syntax. Fix #112