Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: support placeholders for anything #3910

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
f13dc33
Remove pasted imports
MGatner May 23, 2021
cd66294
Add Publisher
MGatner May 23, 2021
18ae7ea
Add tests
MGatner May 24, 2021
116fc82
Apply suggestions from code review
MGatner May 24, 2021
865c73a
Apply additional suggestions
MGatner May 25, 2021
3987bff
Add Guide, tweak class
MGatner May 27, 2021
ad41218
Add Publish command
MGatner May 29, 2021
c974add
Fix test bleeding
MGatner May 29, 2021
5906310
Fix UG format
MGatner May 29, 2021
45d776e
Implement review changes
MGatner Jun 1, 2021
fb70807
Tweak formatting
MGatner Jun 1, 2021
f33d880
Add Publisher restrictions
MGatner Jun 8, 2021
9c0446d
Graphic fix on some screen res
Vizzielli Jun 12, 2021
3b54e81
Merge pull request #4727 from MGatner/publisher
MGatner Jun 13, 2021
5a6f664
Implement FileCollection
MGatner Jun 13, 2021
9e4f9fd
New mock() test helper and expanded MockCache with assertions.
lonnieezell Jun 14, 2021
e019a7f
Update system/Helpers/test_helper.php
lonnieezell Jun 14, 2021
55966e8
Update system/Helpers/test_helper.php
lonnieezell Jun 14, 2021
a2fa932
Update user_guide_src/source/testing/mocking.rst
lonnieezell Jun 14, 2021
d454c87
Merge pull request #4828 from Vizzielli/patch-3
MGatner Jun 15, 2021
157cb3b
Implement define()
MGatner Jun 15, 2021
4e2ecf3
rename `application` to `app`
totoprayogo1916 Jun 15, 2021
fd19629
Merge pull request #4834 from totoprayogo1916/fix-folder-doc
MGatner Jun 15, 2021
ad99778
Declare final methods
MGatner Jun 15, 2021
e1a7506
Apply suggestions from code review
MGatner Jun 15, 2021
5eafc2f
Updated assert to assertArrayNotHasKey per suggestion.
lonnieezell Jun 17, 2021
b332294
Merge branch 'cache-mock' of github.com:codeigniter4/CodeIgniter4 int…
lonnieezell Jun 17, 2021
e0beeb1
Merge branch '4.2' into cache-mock
lonnieezell Jun 17, 2021
463596f
Remove extra use statement in MockCache
lonnieezell Jun 17, 2021
cd0d36a
Replaced code that went missing during merge conflict fixes.
lonnieezell Jun 19, 2021
13ebb96
Merge pull request #4831 from codeigniter4/cache-mock
lonnieezell Jun 21, 2021
8d09d10
Make CLI detection as interface independent as possible
paulbalandan Jun 21, 2021
929e5c4
Added MySQLi resultMode and updated user guide
sclubricants Jun 21, 2021
a5d9c9e
Implement review suggestions
MGatner Jun 23, 2021
3e4415a
Sort timeline elements by start and duration.
Jun 23, 2021
b09afed
Update system/Files/FileCollection.php
MGatner Jun 24, 2021
c9e1f84
Update user_guide_src/source/libraries/files.rst
MGatner Jun 24, 2021
9936bb4
Update tests/system/Files/FileCollectionTest.php
MGatner Jun 24, 2021
6797d1f
Merge pull request #4865 from sfadschm/sort-debugbar-timeline-4.2
MGatner Jun 24, 2021
a351963
Namespace extracted by GeneratorTrait should always end in backslash
paulbalandan Jun 24, 2021
f072c86
Merge pull request #4867 from paulbalandan/spark-command-lost
MGatner Jun 25, 2021
639cf77
Fix bug with respecting TTL in Predis and File cache
michalsn Jun 25, 2021
5a70162
Fix database session bug with timestamp in MySQLi
michalsn Jun 26, 2021
cd4ad9d
Fix for generating session table structure via migrations
michalsn Jun 26, 2021
bf30dab
Update docblock for redirect function [ci skip]
michalsn Jun 27, 2021
84646f5
Fix mysqli ssl connection - certificate is not required to establish …
michalsn Jun 27, 2021
85cd690
Merge pull request #4875 from michalsn/fix/cache-handlers
michalsn Jun 27, 2021
b156db1
Merge pull request #4876 from michalsn/fix/database-session
michalsn Jun 27, 2021
f6cc4de
Merge pull request #4877 from michalsn/fix/migrate-session
michalsn Jun 27, 2021
bb23bc9
Merge pull request #4830 from MGatner/file-collection
MGatner Jun 27, 2021
a988368
Structure debug toolbar timeline with collapsible elements.
Jun 28, 2021
1756de6
Merge pull request #4884 from michalsn/fix/docblock
MGatner Jun 28, 2021
f887865
Merge pull request #4885 from michalsn/fix/mysqli-ssl-connection-requ…
paulbalandan Jun 28, 2021
6d752f4
Merge pull request #4886 from sfadschm/4.2
lonnieezell Jun 28, 2021
5564f9d
Updated Query Build custom string option for where to remove make it …
lonnieezell Jun 30, 2021
9ceb5e3
Merge pull request #4892 from codeigniter4/where-string
lonnieezell Jun 30, 2021
cfed0b1
Finalize SQLSRV schema support for 4.2
qury Jul 2, 2021
32a3aa1
Implement Deptrac
MGatner Jul 3, 2021
b3e4c31
Update Throttler docs [ci skip]
michalsn Jul 4, 2021
016380a
Fix getVar method when trying to get variable that does not exists
michalsn Jul 4, 2021
c5d7484
Merge pull request #4903 from qury/fix/sqlsrv-schema-4.2
MGatner Jul 4, 2021
43db35c
Update tests/system/HTTP/IncomingRequestTest.php
michalsn Jul 4, 2021
f3952eb
Update tests/system/HTTP/IncomingRequestTest.php
michalsn Jul 4, 2021
7e53b51
Merge pull request #4908 from michalsn/fix/throttler-docs
michalsn Jul 4, 2021
bb63702
Add toolbar timer styles to sass files.
Jul 5, 2021
1212bf4
Merge pull request #4909 from michalsn/fix/getVar-for-json
MGatner Jul 5, 2021
e3857cd
Do not overwrite startTime.
Jul 6, 2021
9d8ea6f
Unify scss styling and switch to spaces.
Jul 7, 2021
f0bae59
Replace file header.
Jul 7, 2021
09bc563
Merge pull request #4914 from sfadschm/4.2-starttime
paulbalandan Jul 11, 2021
0680f4f
Enable general benchmarking for filters.
Jul 4, 2021
b17ec97
Merge pull request #4897 from sfadschm/add-filters-timer
paulbalandan Jul 11, 2021
fa889e8
Merge pull request #4910 from sfadschm/4.2-toolbar-scss
paulbalandan Jul 12, 2021
de55021
Simplify Action workflow
MGatner Jul 15, 2021
f2ca69f
Implement transitive dependencies
MGatner Jul 15, 2021
34f18b4
Merge pull request #4905 from MGatner/deptrac
MGatner Jul 16, 2021
ac6cd3a
fix entity-datamap guide wrong (#4937)
monkenWu Jul 19, 2021
2a90f33
Fix splitting of string rules (#4957)
paulbalandan Jul 23, 2021
5ec0fc7
CLI: Prompt: Introduce promptByKey method
element-code Aug 2, 2021
11e4772
CLI: Prompt: Change color of default value to green
element-code Aug 2, 2021
78a0d25
Merge pull request #3912 from element-code/feature-cli-added-prompt-s…
paulbalandan Aug 2, 2021
6e4d5e7
Fix adding foreign keys with only string fields (#4988)
paulbalandan Aug 6, 2021
14e5c32
Validation: support placeholders for anything
element-code Aug 2, 2021
0339f0a
Fix lang() function is overriding locale
pjsde Aug 14, 2021
32e0afd
Merge pull request #5001 from pjsde/fix_lang_function
MGatner Aug 17, 2021
8e16ffc
Add config for cache keys
MGatner Aug 17, 2021
2ec6e00
Fix bug with handling boolean values in set() method in BaseBuilder a…
michalsn Jul 4, 2021
02ba1d6
Update method definition in the user guide
michalsn Jul 4, 2021
4cdaca6
add to toctree
michalsn Jul 23, 2021
795df09
Merge pull request #4907 from michalsn/fix/set
MGatner Aug 18, 2021
d2fe271
Update app/Config/Cache.php
MGatner Aug 18, 2021
dd63db0
Merge pull request #5008 from MGatner/cache-config
MGatner Aug 19, 2021
2253fe6
Merge branch '4.2' into fix-validation-placeholder-replacement
element-code Aug 19, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions .github/workflows/test-deptrac.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# When a PR is opened or a push is made, perform an
# architectural inspection on the code using Deptrac.
name: Deptrac

on:
pull_request:
branches:
- 'develop'
- '4.*'
paths:
- 'app/**'
- 'system/**'
- 'composer.json'
- 'depfile.yaml'
- '.github/workflows/test-deptrac.yml'
push:
branches:
- 'develop'
- '4.*'
paths:
- 'app/**'
- 'system/**'
- 'composer.json'
- 'depfile.yaml'
- '.github/workflows/test-deptrac.yml'

jobs:
build:
name: Architectural Inspection
runs-on: ubuntu-20.04
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.0'
tools: composer, phive
extensions: intl, json, mbstring, gd, mysqlnd, xdebug, xml, sqlite3

- name: Validate composer.json
run: composer validate --strict

- name: Get composer cache directory
id: composer-cache
run: echo "::set-output name=dir::$(composer config cache-files-dir)"

- name: Create composer cache directory
run: mkdir -p ${{ steps.composer-cache.outputs.dir }}

- name: Cache composer dependencies
uses: actions/cache@v2
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
restore-keys: ${{ runner.os }}-composer-

- name: Create Deptrac cache directory
run: mkdir -p build/

- name: Cache Deptrac results
uses: actions/cache@v2
with:
path: build
key: ${{ runner.os }}-deptrac-${{ github.sha }}
restore-keys: ${{ runner.os }}-deptrac-

- name: Install dependencies
run: composer update --ansi --no-interaction

- name: Run architectural inspection
run: |
sudo phive --no-progress install --global qossmic/deptrac --trust-gpg-keys B8F640134AB1782E
deptrac analyze --cache-file=build/deptrac.cache
18 changes: 9 additions & 9 deletions admin/css/debug-toolbar/_graphic-charter.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
// ========================================================================== */

// Themes
$t-dark: #252525;
$t-dark: #252525;
$t-light: #FFFFFF;

// Glossy colors
$g-blue: #5BC0DE;
$g-gray: #434343;
$g-green: #9ACE25;
$g-blue: #5BC0DE;
$g-gray: #434343;
$g-green: #9ACE25;
$g-orange: #DD8615;
$g-red: #DD4814;
$g-red: #DD4814;

// Matt colors
$m-blue: #D8EAF0;
$m-gray: #DFDFDF;
$m-green: #DFF0D8;
$m-blue: #D8EAF0;
$m-gray: #DFDFDF;
$m-green: #DFF0D8;
$m-orange: #FDC894;
$m-red: #EF9090;
$m-red: #EF9090;
13 changes: 7 additions & 6 deletions admin/css/debug-toolbar/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
// ========================================================================== */

@mixin border-radius($radius) {
border-radius: $radius;
-moz-border-radius: $radius;
-webkit-border-radius: $radius;
border-radius: $radius;
-moz-border-radius: $radius;
-webkit-border-radius: $radius;
}

@mixin box-shadow($left, $top, $radius, $color) {
box-shadow: $left $top $radius $color;
-moz-box-shadow: $left $top $radius $color;
-webkit-box-shadow: $left $top $radius $color;
box-shadow: $left $top $radius $color;
-moz-box-shadow: $left $top $radius $color;
-webkit-box-shadow: $left $top $radius $color;
}
Loading