Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set uppercase #4132

Merged
merged 1 commit into from
Jan 18, 2021
Merged

set uppercase #4132

merged 1 commit into from
Jan 18, 2021

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Jan 18, 2021 •
edited
Loading

Description
Dir Config is start with capital

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Jan 18, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be app/Config/App.php?

@totoprayogo1916
Copy link
Contributor Author

should that be app/Config/App.php?

I think yes.
and pushed new commit.

paulbalandan
paulbalandan approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @totoprayogo1916

@paulbalandan paulbalandan merged commit 734aef0 into codeigniter4:develop Jan 18, 2021
@totoprayogo1916 totoprayogo1916 deleted the uppercase branch January 18, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totoprayogo1916 @paulbalandan