New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with respecting TTL in Predis and File cache #4875

Merged

michalsn merged 1 commit into codeigniter4:4.2 from michalsn:fix/cache-handlers

Jun 27, 2021

Member

michalsn commented Jun 25, 2021

Description
After answering a question on Slack I noticed some small bugs in the Predis and File cache handler.

In Predis, we couldn't set the cache as permanent even if we specified 0 as TTL.
In the File cache, we were getting the incorrect expire metadata when a given key was stored as permanent.

This PR fixes these bugs.

Checklist:

Securely signed commits
Unit testing, with >80% coverage
Conforms to style guide


Fix bug with respecting TTL in Predis and File cache

639cf77

MGatner approved these changes

View reviewed changes

paulbalandan approved these changes

View reviewed changes

michalsn merged commit 85cd690 into codeigniter4:4.2

michalsn deleted the fix/cache-handlers branch

September 21, 2022 16:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment