Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize SQLSRV schema support for 4.2 branch #4903

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Finalize SQLSRV schema support for 4.2 branch #4903

merged 1 commit into from
Jul 4, 2021

Conversation

qury
Copy link
Contributor

@qury qury commented Jul 2, 2021

Description
Proper schema support for SQLSRV driver for 4.2 branch
This is related to defect: #4853 and previous PR #4860

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn mentioned this pull request Jul 4, 2021
Closed
5 tasks
michalsn
michalsn approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

MGatner
MGatner approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for Michal, good enough for me 😂

@MGatner MGatner merged commit c5d7484 into codeigniter4:4.2 Jul 4, 2021
@michalsn michalsn mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qury @michalsn @MGatner