Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update admin/framework/composer.json Kint #5531

Merged
merged 1 commit into from
Jan 4, 2022
Merged

chore: update admin/framework/composer.json Kint #5531

merged 1 commit into from
Jan 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 4, 2022 •
edited
Loading

Description

  • update Kint to ^4.0
    • fixes the error Access to undeclared static property Kint\Kint::$depth_limit in appstarter 4.1.6

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the dependencies Pull requests that update external dependencies label Jan 4, 2022
@jsnmrs jsnmrs mentioned this pull request Jan 4, 2022
Merged
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 4, 2022
@kenjis kenjis mentioned this pull request Jan 4, 2022
Closed
@MGatner
Copy link
Member

MGatner commented Jan 4, 2022

Thanks @kenjis. I hotfixed this in place on codeigniter4/framework directly (codeigniter4/framework@557705a) but it still needed fixing here.

@totoprayogo1916
Copy link
Contributor

waiting for release ....

@kenjis
Copy link
Member Author

kenjis commented Jan 4, 2022

@totoprayogo1916 v4.1.6 was re-released.

@totoprayogo1916
Copy link
Contributor

@totoprayogo1916 v4.1.6 was re-released.

Great ... thanks 👍🏻

@paulbalandan paulbalandan mentioned this pull request Jan 4, 2022
Merged
5 tasks
@MGatner MGatner merged commit 7f681bd into codeigniter4:develop Jan 4, 2022
@kenjis kenjis deleted the fix-framework-composer.json branch January 4, 2022 23:34
@kenjis kenjis mentioned this pull request Jan 10, 2022
Merged
8 tasks
MGatner added a commit that referenced this pull request Jan 24, 2022
@MGatner @kenjis
Merge pull request #5531 from kenjis/fix-framework-composer.json
9e9dfbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them dependencies Pull requests that update external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @totoprayogo1916