Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Undefined index: file: SYSTEMPATH\Debug\Toolbar\Collectors\Database.php at line 142 #5543

Closed
wants to merge 1 commit into from
Closed

fix: Undefined index: file: SYSTEMPATH\Debug\Toolbar\Collectors\Database.php at line 142 #5543

wants to merge 1 commit into from

Conversation

iprixi
Copy link

@iprixi iprixi commented Jan 5, 2022 •
edited by kenjis
Loading

  • Fix for using the undefined key of file

Each pull request should address a single issue and have a meaningful title.

Description
Fixes #5539

@iprixi
re codeigniter4#5539
c98389b 
- Fix for using undefined key of file
@iprixi iprixi mentioned this pull request Jan 5, 2022
Closed
@kenjis kenjis added the tests needed Pull requests that need tests label Jan 5, 2022
@kenjis kenjis changed the title re #5539 fix: Undefined index: file: SYSTEMPATH\Debug\Toolbar\Collectors\Database.php at line 142 Jan 5, 2022
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 5, 2022
@kenjis
Copy link
Member

kenjis commented Jan 5, 2022

@iprixi Thank you for sending this PR!

Could you add test code for this?
Set the debug trace like this: #5539 (comment)
and run display() and check the results.

@mkilinskidev
Copy link

Wouldn't be better if you use array_key_exist instead of isset ?

@paulbalandan
Copy link
Member

But a null file does not make sense, is it?

@iprixi
Copy link
Author

iprixi commented Jan 5, 2022

@mkilinskidev why would we want to do a string clean up on a null value?

@kenjis kenjis added the hotfix label Jan 6, 2022
@paulbalandan paulbalandan mentioned this pull request Jan 7, 2022
Merged
5 tasks
@kenjis
Copy link
Member

kenjis commented Jan 7, 2022

Screenshot 2022-01-07 14 44 40

Screenshot 2022-01-07 14 45 00

@kenjis kenjis removed the hotfix label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: ErrorException: Undefined index: file: SYSTEMPATH\Debug\Toolbar\Collectors\Database.php at line 142
4 participants
@iprixi @kenjis @mkilinskidev @paulbalandan