Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throws Exception when getCompiled*() is called in the Model #5562

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Throws Exception when getCompiled*() is called in the Model #5562

merged 3 commits into from
Jan 13, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 11, 2022 •
edited
Loading

Description
Alternative to #5561
Related to #5549

  • throws Exception when getCompiled*() is called in the Model

Reasons:

  • CodeIgniter\Model and Query Builder should not be expected to return the same data. They are separate classes with different purposes.
  • If you need to get the compiled Insert or Update you should do so directly on the Query Builder instance.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Jan 11, 2022
@kenjis kenjis mentioned this pull request Jan 11, 2022
Closed
@kenjis kenjis changed the title Throws Exceptions when getCompiledInsert(),getCompiledUpdate() is called in the Model Throws Exception when getCompiledInsert(),getCompiledUpdate() is called in the Model Jan 11, 2022
@kenjis kenjis force-pushed the throw-exceptions-model-getComplied branch from fb739ad to 3fb2345 Compare January 12, 2022 03:49
@kenjis kenjis changed the title Throws Exception when getCompiledInsert(),getCompiledUpdate() is called in the Model Throws Exception when getCompiled*() is called in the Model Jan 12, 2022
@kenjis kenjis force-pushed the throw-exceptions-model-getComplied branch from 3fb2345 to 9f56103 Compare January 12, 2022 04:04
@kenjis @paulbalandan
fix: the error message
d85a4fd 
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@kenjis kenjis merged commit 673860f into codeigniter4:develop Jan 13, 2022
@kenjis kenjis deleted the throw-exceptions-model-getComplied branch January 13, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @lonnieezell @paulbalandan