Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: CURLRequest and the slow tests #5593

Merged
merged 2 commits into from
Jan 21, 2022
Merged

refactor: CURLRequest and the slow tests #5593

merged 2 commits into from
Jan 21, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 19, 2022

Description
To improve test speed.

  • CURLReqest
    • sleep() -> usleep()
  • Tests
    • delay 1000 -> 100

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 19, 2022
@paulbalandan paulbalandan changed the title refactor: CURLReqest and the slow tests refactor: CURLRequest and the slow tests Jan 20, 2022
@kenjis kenjis merged commit 15716d5 into codeigniter4:develop Jan 21, 2022
@kenjis kenjis deleted the fix-CURLRequestTests branch January 21, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan