Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Controller::validateData() #5639

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 1, 2022

Description

  • $this->validate() can't validate arbitrary data
    • e.g. method parameters, trimmed data
  • This method can validate any user supplied data

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the enhancement PRs that improve existing functionalities label Feb 1, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit unnecessary to me as it just saves a step over using the Validation Service, but if you think it would be beneficial it does synergize nicely with validate() so I'm not opposed.

@kenjis
Copy link
Member Author

kenjis commented Feb 15, 2022

Added method param, documentation.

@kenjis kenjis merged commit fa6494f into codeigniter4:develop Feb 18, 2022
@kenjis kenjis deleted the add-validateData branch February 18, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants