Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: DB Session Handler #5696

Merged
merged 6 commits into from
Mar 23, 2022
Merged

refactor: DB Session Handler #5696

merged 6 commits into from
Mar 23, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 15, 2022 •
edited
Loading

Description

  • make database specific handlers

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft February 15, 2022 03:04
@kenjis kenjis added the refactor Pull requests that refactor code label Feb 15, 2022
@kenjis kenjis marked this pull request as ready for review February 15, 2022 06:30
@kenjis kenjis changed the title refactor: DB Session Hander refactor: DB Session Handler Mar 20, 2022
@kenjis kenjis force-pushed the refactor-db-session-hander branch from f12ea9c to 685a11b Compare March 22, 2022 01:56
@kenjis
Copy link
Member Author

kenjis commented Mar 22, 2022

Rebased to resolve conflicts.

@kenjis kenjis merged commit 91cfc31 into codeigniter4:develop Mar 23, 2022
@kenjis kenjis deleted the refactor-db-session-hander branch March 23, 2022 00:53
@kenjis kenjis mentioned this pull request Mar 27, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @MGatner