Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError when $tokenRandomize = true and no token posted #5742

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 25, 2022

Description
Fixes #5741

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 25, 2022
Comment on lines 281 to 283
if ($rawToken !== null) {
$token = $this->tokenRandomize ? $this->derandomize($rawToken) : $rawToken;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ($rawToken !== null) {
$token = $this->tokenRandomize ? $this->derandomize($rawToken) : $rawToken;
}
$token = $rawToken !== null && $this->tokenRandomize ? $this->derandomize($rawToken) : $rawToken;

@kenjis kenjis merged commit a3c856a into codeigniter4:develop Feb 25, 2022
@kenjis kenjis deleted the fix-csrf-type-error branch February 25, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
4 participants