Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking if the subquery uses the same object as the main query #5743

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Checking if the subquery uses the same object as the main query #5743

merged 2 commits into from
Feb 26, 2022

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented Feb 25, 2022 •
edited by kenjis
Loading

Description
To prevent possible unpredictable behavior, a check has been added for using the same object for the subrequry as the main query.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@iRedds
Checking if the subquery uses the same object as the main query
e7cd0c6 
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Feb 25, 2022
@iRedds @kenjis
Update tests/system/Database/Builder/BaseTest.php
e5bc03d 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik samsonasik merged commit 64b6f48 into codeigniter4:develop Feb 26, 2022
@samsonasik
Copy link
Member

Thank you @iRedds

@iRedds iRedds deleted the subquery-same-object branch February 26, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iRedds @samsonasik @kenjis