Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Publisher $restrictions regex to FCPATH #5793

Merged
merged 4 commits into from
Mar 13, 2022
Merged

fix: Publisher $restrictions regex to FCPATH #5793

merged 4 commits into from
Mar 13, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 11, 2022 •
edited
Loading

Description

  • fix regex

Related: #5792

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 11, 2022
@haugli92
Copy link

haugli92 commented Mar 11, 2022 •
edited
Loading

Add |woff2?|?. Im not the best on regex, can someone validate it?

@kenjis
Copy link
Member Author

kenjis commented Mar 12, 2022

@haugli92 Thanks!
Added.

@kenjis kenjis merged commit feb6bf0 into codeigniter4:develop Mar 13, 2022
@kenjis kenjis deleted the fix-Config/Publisher branch March 13, 2022 07:33
@MGatner
Copy link
Member

MGatner commented Mar 15, 2022

I missed this one but I think it is now unduly restricting .htm files (that was the original intent of htm?. Do we need htm?? for some reason?

@MGatner
Copy link
Member

MGatner commented Mar 15, 2022

Also woff2 should've been covered by woff?, right?

@MGatner
Copy link
Member

MGatner commented Mar 15, 2022

Ah, nope - I'm a dummy, never mind me. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @haugli92 @MGatner @samsonasik