[Rector] Clean up skip config and re-run Rector #5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
clean-up-re-run-rector
branch
from
a6b01b0
to
2888011
Compare
samsonasik
force-pushed
the
clean-up-re-run-rector
branch
from
e484f95
to
4f97aac
Compare
|
All green 🎉 |
mostafakhudair
suggested changes
Mar 19, 2022
Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>
Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>
kenjis
reviewed
Mar 20, 2022
kenjis
reviewed
Mar 20, 2022
kenjis
reviewed
Mar 20, 2022
kenjis
reviewed
Mar 20, 2022
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
MGatner
approved these changes
Mar 20, 2022
system/CodeIgniter.php
Outdated
| @@ -830,7 +830,7 @@ protected function startController() | |||
| $this->benchmark->start('controller_constructor'); | |||
|
|
|||
| // Is it routed to a Closure? | |||
| if (is_object($this->controller) && (get_class($this->controller) === 'Closure')) { | |||
| if (is_object($this->controller) && (get_class($this->controller) === Closure::class)) { | |||
There was a problem hiding this comment.
There isn't by chance a way to "exempt core classes without namespaces" is there?
There was a problem hiding this comment.
Not yet, it possibly need to have configured, eg skip_native_class
There was a problem hiding this comment.
It actually configurable, but currently need to manually define what need to be skipped https://github.com/rectorphp/rector-src/blob/de3c9b6f90ccc901c135a7d9786c4a9ea772bd4d/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php#L118
samsonasik
force-pushed
the
clean-up-re-run-rector
branch
from
0bd15b7
to
0176bb4
Compare
|
I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up skip config
clean unneded skip
RemoveUnusedPrivateMethodRectoron__DIR__ . '/system/CodeIgniter.phpfileonly specificy on specific files on skip
StringClassNameToClassConstantRectordue to internal PHPStan issue for detecting namespaced string for and expected string in testsRe-run Rector
Checklist: