Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove App\ and Config\ in autoload.psr-4 in app starter composer.json #5824

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 23, 2022

Description
Revert #3423
Fixes #5818

Why

If there is a user who wants to use Composer autoloader optimization (dump-autoload -o) for App namespace class files, they could add it in autoload.psr-4 by themself.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

…ser.json

Revert codeigniter4#3423

Problems:
- Cannot change `app` folder name. Because the composer's path overwrite the config in Config\Autoload.
- Causes error when defining new namespace under app/. See codeigniter4#5818
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 23, 2022
@kenjis kenjis requested a review from samsonasik March 23, 2022 09:55
@kenjis kenjis merged commit 503e6be into codeigniter4:develop Mar 24, 2022
@kenjis kenjis deleted the revert-3423 branch March 24, 2022 10:03
@kenjis
Copy link
Member Author

kenjis commented Mar 24, 2022

@samsonasik Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: defining new namespace under app/ causes Cannot declare class ..., because the name is already in use
2 participants