feat: throws exception when controller name in routes contains /
#5885
Conversation
| @@ -426,6 +426,11 @@ protected function checkRoutes(string $uri): bool | |||
| throw RouterException::forDynamicController($handler); | |||
| } | |||
|
|
|||
| // Checks `/` in controller name | |||
| if (strpos($controller, '/') !== false) { | |||
There was a problem hiding this comment.
I wasn't able to find parameters for "valid PHP class names", but would it make sense to expand this out to a regex and fail anything that didn't fit?
There was a problem hiding this comment.
Admin/AdminGlavni is not a valid PHP class name.
Because / is wrong.
Many users write like 'Admin/AdminGlavni::cam_edit_show/$1' and CI4 causes errors.
There was a problem hiding this comment.
Right, I get that. My question was: is there any reason why not to make this check for all class names? Admin\Admin-Glavni is also not valid. This could be implemented as a filter and the error as "Your controller contains the following invalid characters: -"
There was a problem hiding this comment.
Because it is a breaking change.
Admin/AdminGlavni is not valid, but works now.
Description
'Admin/AdminGlavni::cam_edit_show/$1'It is better users know it should be
\than replacing/with\without notice.Because
Admin/AdminGlavniis a wrong classname.See https://forum.codeigniter.com/showthread.php?tid=81681&pid=395315#pid395315
Checklist: