Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing the RouteCollection::getRoutes() method #5918

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Optimizing the RouteCollection::getRoutes() method #5918

merged 1 commit into from
Apr 23, 2022

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented Apr 22, 2022

Description
RouteCollection::getRoutes()
Simplified code to combine routes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@iRedds
Optimizing the RouteCollection::getRoutes() method
2c77ee5 
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
kenjis
kenjis approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis added the refactor Pull requests that refactor code label Apr 23, 2022
@paulbalandan paulbalandan merged commit ec0f3fa into codeigniter4:develop Apr 23, 2022
@iRedds iRedds deleted the routecollection-getroutes branch April 23, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iRedds @kenjis @paulbalandan