Fix decorators #6090
Merged
Fix decorators #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
reviewed
Jun 7, 2022
system/View/ViewDecoratorTrait.php
Outdated
| @@ -24,7 +24,7 @@ protected function decorateOutput(string $html): string | |||
| $decorators = \config('View')->decorators; | |||
|
|
|||
| foreach ($decorators as $decorator) { | |||
| if (! is_subclass_of($decorator, ViewDecoratorInterface::class)) { | |||
There was a problem hiding this comment.
The code seems fine, but did you get the ViewException thrown?
There was a problem hiding this comment.
Yes, the exception was thrown when using is_subclass_of. Not sure how I didn't run into that previously but following the docs I had to make these changes to get it to work.
MGatner
requested changes
Jun 7, 2022
kenjis
approved these changes
Jun 8, 2022
paulbalandan
approved these changes
Jun 8, 2022
kenjis
removed
the
bug
MGatner
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a typo for View Decorators documentation. Also, the current code, while passing tests, wasn't working
for me in a real-word test. Modified to better check the class implements the ViewDecoratorInterface.
Checklist: