Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session cookie name bug #6091

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 7, 2022

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

When option prefix is '0', it is not set correctly.
The config prefix should be ignored.
> the Config\Cookie::$prefix setting is completely ignored.
> https://codeigniter.com/user_guide/libraries/sessions.html#session-preferences
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 7, 2022
@MGatner MGatner changed the title fix: session cooike name bug fix: session cookie name bug Jun 7, 2022
@kenjis kenjis merged commit b63104b into codeigniter4:develop Jun 7, 2022
@kenjis kenjis deleted the fix-session-cooike-name-bug branch June 7, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants