Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reverse routing does not work with full classname starting with \ #6104

Merged
merged 2 commits into from
Jun 11, 2022
Merged

fix: reverse routing does not work with full classname starting with \ #6104

merged 2 commits into from
Jun 11, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 10, 2022 •
edited
Loading

Description
Reported in https://forum.codeigniter.com/showthread.php?tid=82070&pid=396927#pid396927
Follow-up #5936

  • fix handlder starting with \ does not work
    • E.g., url_to('\App\Controllers\backend\Dashboard::index')
  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 10, 2022
@iRedds
Copy link
Collaborator

iRedds commented Jun 10, 2022

Is it possible in this PR to also add [Controller::class, 'method'] handling?

@kenjis
Copy link
Member Author

kenjis commented Jun 10, 2022

No, this is a bug fix.
[Controller::class, 'method'] handling is an enhancement that should go to 4.3.

MGatner
MGatner approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice test refactor.

@kenjis kenjis merged commit 5eb41d6 into codeigniter4:develop Jun 11, 2022
@kenjis kenjis deleted the fix-RouteCollection-namespace-bug branch June 11, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @iRedds @samsonasik @MGatner