Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use lang('HTTP.pageNotFound') on production 404 page #6202

Merged
merged 1 commit into from
Jun 29, 2022
Merged

fix: use lang('HTTP.pageNotFound') on production 404 page #6202

merged 1 commit into from
Jun 29, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 29, 2022 •
edited
Loading

Description
before:

404 - File Not Found

Sorry! Cannot seem to find the page you were looking for.

after:

404 - File Not Found

ページが見つかりません。

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 29, 2022
MGatner
MGatner approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that was just a mistake to begin with.

@samsonasik samsonasik merged commit b306fbc into codeigniter4:develop Jun 29, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-display404errors branch June 29, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @MGatner