Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple pagers with models do not work #6211

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 30, 2022

Description
Fixes #6204

I am not sure if there is something wrong with sharing Pager.
But without sharing the Pager, multiple pagers never work.

See https://codeigniter4.github.io/CodeIgniter4/libraries/pagination.html#paginating-multiple-results

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 30, 2022
@iRedds
Copy link
Collaborator

iRedds commented Jun 30, 2022

Can you add tests for this case?

@kenjis
Copy link
Member Author

kenjis commented Jun 30, 2022

Yes, I will add test later.

@kenjis kenjis force-pushed the fix-model-multiple-pagers branch from f67af0d to 4d20587 Compare June 30, 2022 10:10
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how or why one would "multiple paginate" but it does seem that with grouping we would need the shared Pagination instance. Test verified this.

One suggestion to make the comparison explicit.

tests/system/Models/PaginateModelTest.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't use multiple pagers on the same view
3 participants