Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 404 page might display Exception message in production environment #6333

Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix: 404 page might display Exception message in production environment #6333

merged 2 commits into from
Aug 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 2, 2022

Description
Fixes #6326

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 2, 2022
MGatner
MGatner approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenjis kenjis merged commit 8b77bf2 into codeigniter4:develop Aug 4, 2022
@kenjis kenjis deleted the fix-error_404 branch August 4, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: exception message might display in production
3 participants
@kenjis @MGatner @paulbalandan