Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Kint to 4.2.0 #6436

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2022

Description
Fixes #6429
See https://github.com/kint-php/kint/releases/tag/4.2.0

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis changed the title chore: update kint to 4.2.0 chore: update Kint to 4.2.0 Aug 27, 2022
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Aug 27, 2022
@paulbalandan
Copy link
Member

Wait. Should we pin kint version to ^4.2?

@kenjis
Copy link
Member Author

kenjis commented Aug 28, 2022

Should we pin kint version to ^4.2?

Done.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I haven't thought of this before but... shouldn't Kint be require-dev?

@kenjis
Copy link
Member Author

kenjis commented Aug 28, 2022

shouldn't Kint be require-dev?

I don't know why but Kint is tightly coupled with CodeIgniter.
We can't disable it now.

@paulbalandan
Copy link
Member

I don't know why I haven't thought of this before but... shouldn't Kint be require-dev?

If we are to agree that dd() is a testing-only function then we can move it to require-dev. But no, dd() is used by end users also, not just for the framework's testing use.

@kenjis kenjis merged commit 6a31be4 into codeigniter4:develop Aug 28, 2022
@kenjis kenjis deleted the update-kint-to-420 branch August 28, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Long time to debug (with dd) for enum
4 participants