Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Validation] JSON data may cause "Array to string conversion" error #6467

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix: [Validation] JSON data may cause "Array to string conversion" error #6467

merged 1 commit into from
Sep 2, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 1, 2022 •
edited
Loading

Description
Fixes #6466

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 1, 2022
@kenjis kenjis mentioned this pull request Sep 1, 2022
Closed
@kenjis kenjis force-pushed the fix-validation-json-data branch 2 times, most recently from 4f2b318 to abeff3c Compare September 2, 2022 03:44
@kenjis
Copy link
Member Author

kenjis commented Sep 2, 2022

Rebased and squashed.
Added a check if the array is a list (in the meaning of array_is_list()).

@kenjis kenjis requested a review from MGatner September 2, 2022 03:48
@kenjis kenjis merged commit 62c5d80 into codeigniter4:develop Sep 2, 2022
@kenjis kenjis deleted the fix-validation-json-data branch September 2, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [Validation] JSON data causes Array to string conversion Error
2 participants
@kenjis @MGatner