Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix PHPStan errors #6470

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 2, 2022

Description
PHPStan new version 1.8.3 reports new errors.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

The new version of PHPStan reported:
  Ignored error pattern ... in path ... was not matched in reported errors.
 ------ ------------------------------------------------------------------------------
  Line   system/Model.php
 ------ ------------------------------------------------------------------------------
  657    Offset 'data' on array on left side of ?? always exists and is not nullable.
  683    Offset 'data' on array on left side of ?? always exists and is not nullable.
 ------ ------------------------------------------------------------------------------
@kenjis kenjis added the refactor Pull requests that refactor code label Sep 2, 2022
@kenjis kenjis merged commit 3ba1eb5 into codeigniter4:develop Sep 2, 2022
@kenjis kenjis deleted the fix-phpstan-errors branch September 2, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants