Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redis cache increment/decrement methods #6473

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Fix redis cache increment/decrement methods #6473

merged 1 commit into from
Sep 2, 2022

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Sep 2, 2022 •
edited by kenjis
Loading

Description
Fixes #6385

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 2, 2022
MGatner
MGatner approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@kenjis kenjis merged commit 924b3c4 into codeigniter4:develop Sep 2, 2022
@paulbalandan paulbalandan deleted the redis-incr branch September 3, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: increment/decrement not working in Cache RedisHandler; method "remember" not listed in CacheInterface
3 participants
@paulbalandan @kenjis @MGatner