Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: CodeIgniter::generateCacheName() #6498

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented Sep 5, 2022

Description
Optimizing the code for getting the URL in the CodeIgniter::generateCacheName() method.
The change uses cloning the URL object and modifying the properties, instead of calling URI::createURIString() directly with arguments.

The code is more compact.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@iRedds iRedds added the refactor Pull requests that refactor code label Sep 5, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thank you @iRedds

@MGatner MGatner merged commit 31ae195 into codeigniter4:develop Sep 6, 2022
@iRedds iRedds deleted the refactor/cache-name-generator branch September 9, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants