Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreleased Time::toDatabase() #6509

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Remove unreleased Time::toDatabase() #6509

merged 1 commit into from
Sep 8, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2022

Description
Remove Time::toDatabase() #6431 because the method is now exactly the same as __toString().
See #6461

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Sep 8, 2022
MGatner
MGatner approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full circle it is 🙃

@kenjis kenjis merged commit f9da5ad into codeigniter4:4.3 Sep 8, 2022
@kenjis kenjis deleted the remove-Time-toDatabase branch September 8, 2022 11:16
This was referenced Sep 8, 2022
Merged
Closed
@kenjis kenjis mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan